Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wiring] system: minor fix for sleep configuration method #2231

Merged
merged 1 commit into from
Nov 3, 2020
Merged

[wiring] system: minor fix for sleep configuration method #2231

merged 1 commit into from
Nov 3, 2020

Conversation

XuGuohui
Copy link
Member

@XuGuohui XuGuohui commented Nov 2, 2020

Problem

uint8_t* in SystemSleepConfiguration& SystemSleepConfiguration::gpios(const uint8_t* pins, size_t count, InterruptMode mode) should be replaced with pin_t*.

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@XuGuohui XuGuohui added this to the 3.0.0 milestone Nov 2, 2020
@XuGuohui XuGuohui added ready to merge PR has been reviewed and tested and removed needs review labels Nov 3, 2020
@XuGuohui XuGuohui merged commit c21d5b8 into develop Nov 3, 2020
@XuGuohui XuGuohui deleted the fix/sleep_pin_array branch November 3, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avtolstoy avtolstoy avtolstoy approved these changes

Assignees
No one assigned
Labels
bug ready to merge PR has been reviewed and tested
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@XuGuohui @avtolstoy